Inactive records in entity select

[christophscheuing]

Closes #1983

Functionality already there, but still working on the tests.

[github-actions]

Deployed to https://pr-2056.aam-digital.net/

[christophscheuing]

Unfortunately making the message "None, but XX inactive found" itself clickable hasn't worked out. But UI-wise it should also be OK if this message is only a non-clickable hint and if the user has to click on the option with the checkbox in the entry below.

[TheSlimvReal]

The functionality already looks good. But I would have a little wish-list to make the component a little clearer

• I don't see a reason why the filter function every time applies the additionalFilter and the isSelected check. This rarely changes. Can we instead create a relevantEntities property that only holds the entities which pass these two checks, so the filter function only does the filtering based on the search term.
• I don't like the multiple calls of the getNumberOfInactive function and also the complicated way to get this number. Let's rather have two arrays filteredEntities which holds the actually displayed entities (as it is currently) and inactiveFilteredEntities which only holds the inactive ones that match the filter. Both are calculated based on the relevantEntities, as described before, inside the filter function. This way we drastically remove the amount of times this has to be calculated and it also makes the code a little more straight forward.

Let me know if you need more details.

[sleidig]

@christophscheuing thanks for implementing this! Looks pretty good to me now. I had a few questions and small remarks still, however.

[sleidig]

Great 👍

[aam-digital-ci]

🎉 This PR is included in version 3.31.1-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[aam-digital-ci]

🎉 This PR is included in version 3.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀