Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): implement RoutedViewComponent #2062

Merged
merged 5 commits into from
Nov 7, 2023
Merged

refactor(core): implement RoutedViewComponent #2062

merged 5 commits into from
Nov 7, 2023

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Nov 6, 2023

to generalize loading of config from route data

as a basis for the new admin / setup UI

⚠️ mark as codo

Copy link

github-actions bot commented Nov 6, 2023

Deployed to https://pr-2062.aam-digital.net/

@sleidig sleidig requested a review from TheSlimvReal November 6, 2023 13:23
@sleidig sleidig marked this pull request as ready for review November 6, 2023 13:24
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good idea and nice to see how easy it was to implement this. This makes the difference between route components and panel components even smaller. That might be useful at one point.

@TheSlimvReal
Copy link
Collaborator

Can you explain a little why this is needed in general? What will change with the admin UI?

@sleidig
Copy link
Member Author

sleidig commented Nov 7, 2023

Can you explain a little why this is needed in general? What will change with the admin UI?

In general, I've had the thought to make components usable in both dialog popups and main full-screen views. (Although here I realized that making the Dialog-based components generic is still some more work, so skipping this here for now)
In particular, with regards to the Admin UI, I wanted to keep the components to configure views and entities independent of router data because we might want to display these inside some kind of stepper for a guided setup process also.

As a bonus: Also easier to use in Storybook ;-)

@sleidig sleidig merged commit 66afc76 into master Nov 7, 2023
5 of 6 checks passed
@sleidig sleidig deleted the routed-view branch November 7, 2023 17:48
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 8, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants