-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): implement RoutedViewComponent #2062
Conversation
Deployed to https://pr-2062.aam-digital.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good idea and nice to see how easy it was to implement this. This makes the difference between route components and panel components even smaller. That might be useful at one point.
src/app/child-dev-project/attendance/add-day-attendance/add-day-attendance.component.ts
Outdated
Show resolved
Hide resolved
src/app/child-dev-project/children/children-list/children-list.component.ts
Show resolved
Hide resolved
src/app/core/entity-details/entity-details/entity-details.component.ts
Outdated
Show resolved
Hide resolved
Can you explain a little why this is needed in general? What will change with the admin UI? |
In general, I've had the thought to make components usable in both dialog popups and main full-screen views. (Although here I realized that making the Dialog-based components generic is still some more work, so skipping this here for now) As a bonus: Also easier to use in Storybook ;-) |
🎉 This PR is included in version 3.26.0-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
to generalize loading of config from route data
as a basis for the new admin / setup UI