Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Game #60

wants to merge 2 commits into from

Conversation

kashish-219
Copy link

I have added connect 4 game in the javascript folder.
In this if er get 4 same colour in sequence then we win.
If the code is okay,then can you merge the request and add hacktoberfest-accepted label to the request.
github- kashish-219

Copy link
Owner

@Aanchi-glitch2744 Aanchi-glitch2744 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some bugs that needs to be resolved before merging:

  1. The folder shall be inside JavaScriptLogic and not under JavaScriptLogic/Rock Paper Scissors.
  2. The code you have shared in not working correctly, i.e. none of the players is able to click on the circle buttons in the board. Correct it.
    3)Optional: Use online jquery rather than downloading a file for query. It's very prone to bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants