Skip to content

Commit

Permalink
Rollup merge of rust-lang#100387 - cjgillot:hygiene-trait-impl, r=pet…
Browse files Browse the repository at this point in the history
…rochenkov

Check uniqueness of impl items by trait item when applicable.

When checking uniqueness of item names in impl blocks, we currently use the same definition of hygiene as for toplevel items.  This means that a plain item and one generated by a macro 2.0 do not collide.

This hygiene rule does not match with how impl items resolve to associated trait items. As a consequence, we misdiagnose the trait impls.

This PR proposes to consider that trait impl items are uses of the corresponding trait items during resolution, instead of checking for duplicates later. An error is emitted when a trait impl item is used twice.

There should be no stable breakage, since macros 2.0 are still unstable.

r? ``@petrochenkov``
cc ``@RalfJung``

Fixes rust-lang#71614.
  • Loading branch information
matthiaskrgr authored Oct 11, 2022
2 parents f186abe + bd78f3b commit 083b09f
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 083b09f

Please sign in to comment.