Update Parlour and resolve root namespaces #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the version of Parlour to the latest (8.x) and also fixes a bug where the root
Namespace
Parlour type was not being parsed.tapioca
exports classes in fully namespaced forms, so e.g. it prints this for theruby-kafka
gem:This wasn't being picked up by
sord
because theKafka
constant is actually aParlour::RbiGenerator::Namespace
, which was not in the list of checked classes.This PR allows for continuing to check the children of the root Namespace class without adding the namespace itself to the list of paths.
Note - took another look at this and Parlour is no longer shipping with an
rbi
folder - in fact, it seems like having anrbi
folder in gems is no longer the accepted practice. This caused tests to fail. I've combined my previous PR with this and changed it so that it no longer checks these directories and in fact only checks thesorbet
local directory.Note 2 - looked again and other than issue #101 I haven't actually seen other problems with this. Going to put the RBI back and I found a different way to make the test pass.