Grant job patch permission #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
=========================================
Coverage 96.13% 96.13%
Complexity 89 89
=========================================
Files 12 12
Lines 414 414
Branches 12 12
=========================================
Hits 398 398
Misses 12 12
Partials 4 4 ☔ View full report in Codecov by Sentry. |
AbdelrhmanHamouda
approved these changes
Jul 4, 2024
|
Thank you @yuriipolishchuk first, for taking the time and second, for finding this bug and contributing back to the project 🚀 Fix looks good. |
|
@yuriipolishchuk, version 0.9.1 has been released and can be directly used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Here's a fix for an issue we found after upgrading from 0.8.0 to 0.9.0 we have an error stating that the operator cannot patch a k8s job:
2024-07-04 15:09:31,955 ERROR [ReconcilerExecutor-locusttestreconciler-480] com.locust.operator.controller.utils.resource.manage.ResourceCreationManager: Exception occurred during Job creation: Failure executing: PATCH at: https://10.100.0.1:443/apis/batch/v1/namespaces/locust/jobs/locust-email-reports-test-worker?fieldManager=fabric8. Message: jobs.batch "locust-email-reports-test-worker" is forbidden: User "system:serviceaccount:locust:locust-operator-locust-k8s-operator" cannot patch resource "jobs" in API group "batch" in the namespace "locust". Received status: Status(apiVersion=v1, code=403, details=StatusDetails(causes=[], group=batch, kind=jobs, name=locust-email-reports-test-worker, retryAfterSeconds=null, uid=null, additionalProperties={}), kind=Status, message=jobs.batch "locust-email-reports-test-worker" is forbidden: User "system:serviceaccount:locust:locust-operator-locust-k8s-operator" cannot patch resource "jobs" in API group "batch" in the namespace "locust", metadata=ListMeta(_continue=null, remainingItemCount=null, resourceVersion=null, selfLink=null, additionalProperties={}), reason=Forbidden, status=Failure, additionalProperties={}).