Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Exclude String filters in favour of Callback Functions. #204

Conversation

aliumujib
Copy link
Contributor

Context:

Relates to #203

@prabirshrestha
Copy link
Collaborator

Can we use a callback function instead to filter? This allows it to easily be customizable to any logic.

@aliumujib
Copy link
Contributor Author

Can we use a callback function instead to filter? This allows it to easily be customizable to any logic.

Great idea! @prabirshrestha . I have updated the PR to use a callback function.

@aliumujib aliumujib changed the title Feature/add support for regex filtering Changed Exclude String filters in favour of Callback Functions. Aug 20, 2024
@prabirshrestha
Copy link
Collaborator

Can we combine fille filter and dir filter together and take an object instead of &str. In the future we may have other options such as symbolic link.

@aliumujib
Copy link
Contributor Author

Can we combine fille filter and dir filter together and take an object instead of &str. In the future we may have other options such as symbolic link.

Done! @prabirshrestha

@prabirshrestha prabirshrestha merged commit b0befa0 into Abraxas-365:main Aug 21, 2024
2 checks passed
@prabirshrestha
Copy link
Collaborator

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants