Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support image messages for OpenAI #214

Closed
wants to merge 5 commits into from
Closed

Conversation

solodolo
Copy link
Contributor

@solodolo solodolo commented Sep 3, 2024

Allows sending images, either URLs or Base64 strings, to OpenAI. This enables support for OpenAI's vision capabilities, similar to the support added for Ollama here.

I'm relatively new to Rust and I'm open to feedback about my approach, so please review with a critical eye. Thanks!

@solodolo solodolo marked this pull request as ready for review September 3, 2024 05:36
@prabirshrestha
Copy link
Collaborator

Can you update the image to be local instead. Can be a small image. I'm not a fan of urls that are not part of the source code as it can cause security issues that we can't control.

@solodolo
Copy link
Contributor Author

solodolo commented Sep 4, 2024

Can you update the image to be local instead. Can be a small image. I'm not a fan of urls that are not part of the source code as it can cause security issues that we can't control.

@prabirshrestha I realized I have the incorrect head branch for this PR. Closing in favor of #215 where I implemented your suggestion in 80efb85.

@solodolo solodolo closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants