Parsing of unprototyped function types in casts #431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the context of casts, the unprotototyped function type
int (*)()
is parsed like the prototyped function typeint (*)(void)
. This causes the following example to be rejected:CompCert complains that a function of zero arguments is applied to one argument. This example is accepted by GCC and Clang, and seems correct according to the ISO C standards.
This is probably a leftover from the days when CompCert didn't fully support unprototyped functions.
It's only casts that have this problem; declarations are correctly parsed, e.g.
int (*f)();
andint (*f)(void);
have different types.This PR is the trivial fix for this problem. It needs some testing, though.