Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation with Coq master #492

Closed
wants to merge 1 commit into from

Conversation

SkySkimmer
Copy link
Contributor

A goal is solved with master but I guess not with whatever version you tested.

See also coq/coq#17660

A goal is solved with master but I guess not with whatever version you
tested.

See also coq/coq#17660
@maximedenes
Copy link
Contributor

How does this relate to #491 ? Is one of the two preferable?

@SkySkimmer
Copy link
Contributor Author

I didn't see #491
I guess compcert maintainers can pick the one they prefer

@ppedrot
Copy link
Contributor

ppedrot commented May 30, 2023

I think the other one is a bit more robust (it doesn't depend on a fixed goal number).

@xavierleroy
Copy link
Contributor

Thank you both for the fixes. I'm about to merge #491 since it looks more robust indeed.

I'm still very surprised that the new "auto" in Coq master can kill one of the goals of this proof entirely, while not breaking anything else in CompCert...

@SkySkimmer SkySkimmer deleted the fix-master branch May 31, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants