Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server -> DB: Add pulling DB login credentials via AWS Secrets #107

Closed
lsulak opened this issue Nov 1, 2023 · 0 comments · Fixed by #153
Closed

Server -> DB: Add pulling DB login credentials via AWS Secrets #107

lsulak opened this issue Nov 1, 2023 · 0 comments · Fixed by #153
Assignees
@TebaleloS
Labels
DB Issues touching the Database part of the project enhancement New feature or request Server Issues touching the server part of the project
Milestone
Atum release 0.2

Comments

@lsulak
Copy link
Collaborator

lsulak commented Nov 1, 2023

Background

Please have inspiration in https://github.com/absa-group/AUL/pull/1907.
@lsulak lsulak added enhancement New feature or request DB Issues touching the Database part of the project Server Issues touching the server part of the project labels Nov 1, 2023
@TebaleloS TebaleloS self-assigned this Nov 22, 2023
TebaleloS added a commit that referenced this issue Nov 28, 2023
@TebaleloS
Fixes #107 - defined a class to retrieve aws secret
ac41c82
TebaleloS added a commit that referenced this issue Nov 28, 2023
@TebaleloS
Fixes #107 - changed class to an object
420b4c8
TebaleloS added a commit that referenced this issue Nov 28, 2023
@TebaleloS
Fixes #107 - redefined the secret key and region
48d99da
TebaleloS added a commit that referenced this issue Nov 30, 2023
@TebaleloS
Fixes #107 - Added license
fc3972c
TebaleloS added a commit that referenced this issue Nov 30, 2023
@TebaleloS
Fixes #107 - Defining the test case
a96e577
TebaleloS added a commit that referenced this issue Nov 30, 2023
@TebaleloS
Fixes #107 - removed asses statement
dd857f1
TebaleloS added a commit that referenced this issue Nov 30, 2023
@TebaleloS
Fixes #107 - Added some scala doc
f98b794
TebaleloS added a commit that referenced this issue Nov 30, 2023
@TebaleloS
Fixes #107 - Modified the client defination
36b71e4
@lsulak lsulak added this to the Next major release milestone Jan 18, 2024
TebaleloS added a commit that referenced this issue Jan 23, 2024
@TebaleloS
Fixes #107 - Added some properties
07340fe
TebaleloS added a commit that referenced this issue Jan 23, 2024
@TebaleloS
Closes #107 - Changed test cases to mock the RetrieveAwsSecret class
402989a
TebaleloS added a commit that referenced this issue Jan 23, 2024
@TebaleloS
Closes #107 - Re-commented out TestServiceSpec.scala
d882b72
TebaleloS added a commit that referenced this issue Jan 23, 2024
@TebaleloS
Closes #107 - Wrapped RetrieveAwsSecret response with Try in the test…
7b722db 
… class
TebaleloS added a commit that referenced this issue Jan 23, 2024
@TebaleloS
Closes #107 - Modified the class name to match the file name
f037cf0
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Closes #107 - resolved GitHub issues
d1d4fde
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Merge branch 'master' into feature/#107-Server-DB-Add-pulling-DB-logi…
fae6fbd 
…n-credentials-via-AWS-Secrets
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Closes #107 - added GitHub suggestions
851a212
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Closes #107 - refactored retrieveAwsSecret to solve the GitHub comments
9628b50
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Closes #107 - removed RetrieveAwsSecret default value
80f2aac
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Merge remote-tracking branch 'origin/master' into feature/#107-Server…
fbb1199 
…-DB-Add-pulling-DB-login-credentials-via-AWS-Secrets

# Conflicts:
#	project/Dependencies.scala
#	server/src/main/resources/example.application.properties.example
#	server/src/main/scala/za/co/absa/atum/server/api/AtumService.scala
#	server/src/main/scala/za/co/absa/atum/server/api/provider/PostgresAccessProvider.scala
#	server/src/test/scala/za/co/absa/atum/server/api/ConfigProviderSpec.scala
TebaleloS added a commit that referenced this issue Feb 1, 2024
@TebaleloS
Closes #107
e7f2708
@salamonpavel salamonpavel mentioned this issue Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TebaleloS TebaleloS

Labels
DB Issues touching the Database part of the project enhancement New feature or request Server Issues touching the server part of the project
Projects
CPS small repos project
Archived in project
Milestone
Atum release 0.2
Development

Successfully merging a pull request may close this issue.

aws secrets provider AbsaOSS/atum-service
2 participants
@lsulak @TebaleloS