Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryResultRow does not instantiate the row data #4

Closed
benedeki opened this issue Nov 10, 2023 · 1 comment · Fixed by #29
Closed

QueryResultRow does not instantiate the row data #4

benedeki opened this issue Nov 10, 2023 · 1 comment · Fixed by #29
Labels
bug Something isn't working

Comments

@benedeki
Copy link
Contributor

Describe the bug

QueryResultRow does not instantiate the row data, instead it just references the mutable JDBC ResultSet. That can be moved away from the expected row or closed completely.

To Reproduce

Returned data from DBTable.insert cannot be retrieved.

Expected behavior

Instantiate the row data, so working with the iterator is safer (also can safely use toList)
@benedeki benedeki added the bug Something isn't working label Nov 10, 2023
@benedeki
Copy link
Contributor Author

Perhaps this will help with solution https://stackoverflow.com/questions/21024224/fetch-an-entire-row-with-jdbc-as-a-list

@benedeki benedeki moved this from 🆕 To groom to 🏗 In progress in CPS small repos project Aug 16, 2024
benedeki added a commit that referenced this issue Aug 16, 2024
@benedeki
#4: QueryResultRow does not instantiate the row data
9f84b12 
* WIP
benedeki added a commit that referenced this issue Aug 16, 2024
@benedeki
#4: QueryResultRow does not instantiate the row data
70a5cc0 
* `QueryResultRow` is now instantiated, so can be used even after connection close
* `JsonBString` deprecated, replaced by `SimpleJsonString`
* setup for separation of unit and integration tests
* integration tests database setup
* github build action enhanced to support integration tests
@benedeki benedeki mentioned this issue Aug 16, 2024
Merged
@benedeki benedeki moved this from 🏗 In progress to 👀 In review in CPS small repos project Aug 17, 2024
benedeki added a commit that referenced this issue Aug 26, 2024
@benedeki @lsulak
#4: QueryResultRow does not instantiate the row data (#29)
dad52d8 
* `QueryResultRow` is now instantiated, so can be used even after connection close
* `JsonBString` deprecated, replaced by `SimpleJsonString`
* setup for separation of unit and integration tests
* integration tests database setup
* github build action enhanced to support integration tests

---------

Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in CPS small repos project Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#4: QueryResultRow does not instantiate the row data AbsaOSS/balta
1 participant
@benedeki