Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to delete data from table #42

Closed
lsulak opened this issue Oct 2, 2024 · 0 comments · Fixed by #45
Closed

Add possibility to delete data from table #42

lsulak opened this issue Oct 2, 2024 · 0 comments · Fixed by #45
Labels
enhancement New feature or request

Comments

@lsulak
Copy link
Collaborator

lsulak commented Oct 2, 2024 •
edited
Loading

Background

As the title says. Sometimes, in our tests, data is being inserted into real tables (outside Balta, e.g. a service test in which the server is sending data to DB via a DB layer), and it's a good practice to remove it.

Perhaps all the data from a table, perhaps only certain using WHERE clause (could be in another ticket if it's technically complicated on the first iteration).

Nevertheless, this feature is very good to have as it would make our interactions with DB in some tests easier.
@lsulak lsulak added the enhancement New feature or request label Oct 2, 2024
@lsulak lsulak changed the title Feature request: add possibility to delete data from table Feature request: add possibility to delete data from table (explicitly) Oct 2, 2024
@lsulak lsulak changed the title Feature request: add possibility to delete data from table (explicitly) Feature request: add possibility to delete data from table (manually / explicitly) Oct 2, 2024
@benedeki benedeki changed the title Feature request: add possibility to delete data from table (manually / explicitly) Add possibility to delete data from table Oct 10, 2024
benedeki added a commit that referenced this issue Oct 16, 2024
@benedeki
#42 Add possibility to delete data from table
55213e0 
* add methods `delete` to `DBTable` in several overloaded flavors
* fixed `addNull` evaluation bug on `DBTable`
* added license entries to testing SQLs
* `DBTable` covered by integration tests
@benedeki benedeki mentioned this issue Oct 16, 2024
Merged
benedeki added a commit that referenced this issue Oct 22, 2024
@benedeki @miroslavpojer
#42 Add possibility to delete data from table (#45)
9d216c2 
* added methods `delete` to `DBTable` in several overloaded flavors
* fixed `addNull` evaluation bug on `DBTable`
* added license entries to testing SQLs
* `DBTable` covered by integration tests

---------

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
@github-project-automation github-project-automation bot moved this from 🆕 To groom to ✅ Done in CPS small repos project Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#42 Add possibility to delete data from table AbsaOSS/balta
1 participant
@lsulak