Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBTestSuite: parametrize persist_data into constructor #43

Closed
lsulak opened this issue Oct 2, 2024 · 0 comments · Fixed by #46
Closed

DBTestSuite: parametrize persist_data into constructor #43

lsulak opened this issue Oct 2, 2024 · 0 comments · Fixed by #46
Labels
enhancement New feature or request

Comments

@lsulak
Copy link
Collaborator

lsulak commented Oct 2, 2024

Background

As the PR title says. Basically it's a bit limiting to have this only in configuration.
@lsulak lsulak added the enhancement New feature or request label Oct 2, 2024
@benedeki benedeki moved this from 🆕 To groom to 🏗 In progress in CPS small repos project Oct 16, 2024
@benedeki benedeki changed the title Feature request: DBTestSuite: parametrize persist_data into constructor DBTestSuite: parametrize persist_data into constructor Oct 16, 2024
benedeki added a commit that referenced this issue Oct 16, 2024
@benedeki
#43: DBTestSuite: parametrize persist_data into constructor
55ec68f 
* make it easy to override data persitence in the `DBTestSuite` class, without the need to override functions.
@benedeki benedeki mentioned this issue Oct 16, 2024
Merged
benedeki added a commit that referenced this issue Oct 23, 2024
@benedeki @miroslavpojer
#43: DBTestSuite: parametrize persist_data into constructor (#46)
83ade05 
* #43: DBTestSuite: parametrize persist_data into constructor
* make it easy to override data persitence in the `DBTestSuite` class, without the need to override functions.
 * fixed `check_pr_release_notes.yml` code to cope with `

---------

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in CPS small repos project Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
CPS small repos project
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#43: DBTestSuite: parametrize persist_data into constructor AbsaOSS/balta
1 participant
@lsulak