Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#35: Simplify working with the query results in the DB tests #37

Conversation

benedeki
Copy link
Contributor

  • method @= for Option types as a synonym for contains
  • method 'noMoreas an alias forhasMoreinQueryResult` class
  • enhanced tests for QueryResultRowIntegration

Closes #35

* method `@=` for Option types as a synonym for `contains`
* method 'noMore` as an alias for `hasMore` in `QueryResult` class
* enhanced tests for `QueryResultRowIntegration`
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pull
  • code review
  • run test

I miss mention in README.md how to run Unit tests - sbt test.

miroslavpojer
miroslavpojer previously approved these changes Sep 26, 2024
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing mention of sbt test is solved in another PR.

benedeki and others added 3 commits September 27, 2024 22:48
…ct]` to `Option[Any]`

* added method `QueryResultRow.getObject`
…he-db-tests' of https://github.com/AbsaOSS/balta into feature/35-simplify-working-with-the-query-results-in-the-db-tests
Copy link

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project 30.13% -5.21% 🍏
Files changed 34.03% 🍏

File Coverage
QueryResultRow.scala 90.43% -5.22% 🍏
QueryResult.scala 82.47% -7.22% 🍏
OptionImplicits.scala 31.82% 🍏
SetterFnc.scala 0% 🍏

@benedeki benedeki merged commit 471bb02 into master Oct 1, 2024
7 checks passed
@benedeki benedeki deleted the feature/35-simplify-working-with-the-query-results-in-the-db-tests branch October 24, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify working with the query results in the DB tests
3 participants