-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#35: Simplify working with the query results in the DB tests #37
Merged
benedeki
merged 6 commits into
master
from
feature/35-simplify-working-with-the-query-results-in-the-db-tests
Oct 1, 2024
Merged
#35: Simplify working with the query results in the DB tests #37
benedeki
merged 6 commits into
master
from
feature/35-simplify-working-with-the-query-results-in-the-db-tests
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* method `@=` for Option types as a synonym for `contains` * method 'noMore` as an alias for `hasMore` in `QueryResult` class * enhanced tests for `QueryResultRowIntegration`
benedeki
requested review from
miroslavpojer,
lsulak and
salamonpavel
as code owners
September 25, 2024 18:24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- pull
- code review
- run test
I miss mention in README.md how to run Unit tests - sbt test
.
miroslavpojer
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing mention of sbt test
is solved in another PR.
…-results-in-the-db-tests
…ct]` to `Option[Any]` * added method `QueryResultRow.getObject`
…he-db-tests' of https://github.com/AbsaOSS/balta into feature/35-simplify-working-with-the-query-results-in-the-db-tests
…-results-in-the-db-tests
JaCoCo 'balta' module code coverage report - scala 2.12.18
|
lsulak
approved these changes
Oct 1, 2024
benedeki
deleted the
feature/35-simplify-working-with-the-query-results-in-the-db-tests
branch
October 24, 2024 13:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@=
for Option types as a synonym forcontains
as an alias for
hasMorein
QueryResult` classQueryResultRowIntegration
Closes #35