#51: Simplify usage by offering combined classes #52
Conversation
* `DBMultipleResultFunction` added * `DBMultipleResultFunctionWithStatusSupport` added * `DBOptionalResultFunction` added * `DBOptionalResultFunctionWithStatusSupport` added * `DBSingleResultFunction` added * `DBSingleResultFunctionWithStatusSupport`
Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>
| } | ||
|
|
||
| /** | ||
| @see [[za.co.absa.fadb.DBFunction.DBSingleResultFunction]] |
There was a problem hiding this comment.
btw I would be as harsh as this - let's remove all the code doc (these params) and have a "one liner" containing just this @see for the whole class
benedeki
added
the
work in progress
|
Doc is suddenly failing - on a class that has not been changed. But found other (naming) issues, that I want to address. |
|
The topic of this PR has been addressed in PR #106. I believe we can close this one. |
|
|
||
| object DBFunction { | ||
| /** | ||
| * Combines [[za.co.absa.fadb.DBFunction.DBMultipleResultFunction DBMultipleResultFunction]] with Slick and Postgres support |
There was a problem hiding this comment.
| * Combines [[za.co.absa.fadb.DBFunction.DBMultipleResultFunction DBMultipleResultFunction]] with Slick and Postgres support | |
| * Combines [[za.co.absa.fadb.DBFunction.DBMultipleResultFunction]] with Slick and Postgres support |
❓
| } | ||
|
|
||
| /** | ||
| * Combines [[za.co.absa.fadb.DBFunction.DBSingleResultFunction DBSingleResultFunction]] with Slick and Postgres support |
There was a problem hiding this comment.
| * Combines [[za.co.absa.fadb.DBFunction.DBSingleResultFunction DBSingleResultFunction]] with Slick and Postgres support | |
| * Combines [[za.co.absa.fadb.DBFunction.DBSingleResultFunction]] with Slick and Postgres support |
There was a problem hiding this comment.
and so on for the rest of them below
There was a problem hiding this comment.
I don't see much value in this PR to be fair :( I think that users should combine whatever they want and that this code brings only very little convenience, but the drawback is that it's a code and each code must be maintained, tested, understood, and documented.
Besides, I think that something like this was already implemented recently and thus I propose to close this PR. For Slick, see this: https://github.com/AbsaOSS/fa-db/pull/106/files#diff-b585ca0e03975d3e0dbdbedca5e6a38f067b043218992ebf9e20dc03b98af2c4 and Doobie has its equivalent in relevant files
DBMultipleResultFunctionaddedDBMultipleResultFunctionWithStatusSupportaddedDBOptionalResultFunctionaddedDBOptionalResultFunctionWithStatusSupportaddedDBSingleResultFunctionaddedDBSingleResultFunctionWithStatusSupportCloses #51