-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think this is all that's needed #7
Conversation
Is the action failing here because it is currently unsupported or is there something else going on? |
My guess is that those symbols are only available in the beta version of 3.13 onwards, while CI is still using an alpha version. I can at least verify that it doesn't work on 3.13.0a6 on my machine, providing a similar message. |
Was added after alpha1, but before beta1: python/cpython#116882 CI needs to be updated I guess, idk if that should be part of the same pull or not, I can do that one way or another. |
Happy to discuss a bit more, but if you could rebase from |
rebased over main, but this likely shouldn't be merged until it can be confirmed that this will build properly under the free-threaded builds, which CIBW won't support until beta2
|
Looks like pypa/cibuildwheel#1854 was merged and I updated to include that. This should be good to merge now if you're happy with it? |
should be fine from everything I'm aware of for this. |
I need to double-check a few things later, but conceptually, this should be all that's needed since this already wasn't manually manipulating the GIL or relying on it implicitly.Should be ready to go, wheel built fine and imported fine on beta 1 on linux, and there shouldn't be anything platform specific about this.