Simplest CUDA half type conflict resolution implementation. #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation will simply place half into a namespace if compiling for the cuda kernel to prevent conflicts with the identically named cuda half type.
Note: A few definitions needed to be moved around to avoid placing functions within the namespace and breaking existing testing. (operator <<, >>, and printBits)
Issues moving forward:
1: Testing of the cuda::half type's behaviour can be added, however the cuda half type is more picky about comparison and type conversion. For instance:
Will produce compiler errors if written with the cuda half (but not for imath::half). It must instead be written this way:
2: The cuda half type also can not be created on host code and therefore printing using cout will not be trivial. Most tests use this heavily.
The bottom line: making the cuda::half behave just as the imath::half type requires considerable reworking and does not seem to be fully attainable for many reasons.
Certainly testing can be done it will just not be the same as the testing already implemented under HalfTest/