Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing PylmathShear.cpp using pybind11 #468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shreyas-koduvayur
Copy link

I did it in the pybind11 format

Copy link

linux-foundation-easycla bot commented Feb 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shreyas-koduvayur (6fb2094)

Signed-off-by: shreyas-koduvayur <kshreyas729@gmail.com>
@cary-ilm
Copy link
Member

Thanks for the contribution!

Because we are building up the pybind11 implementation incrementally, we have structured the repo so that the new implementation is under src/pybind11, in parallel with the long-standing implementation in src/python. Your implementation looks sound, except that it overwrites the src/python implementation, whereas we'd prefer it to go in a new file src/pybind11/PyBindImath/PybinBindImathShear.cpp. Note also that you'll need to add this to src/pybind11/CMakeFile.txt, and you also need to invoke register_imath_shear from the module definition in src/pybind11/PyBindImath/pybindimathmodule.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants