Simplify thin-film layering into thin-film BSDF parameters #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thin-film results should remain unchanged. Here's a before/after comparison for StandardSurface: And here's a before/after comparison for GltfPbr: |
There was a problem hiding this comment.
@niklasharrysson This looks like a great improvement, but perhaps we should leave our data libraries (e.g. libraries/bxdf) unchanged for now, so that we can continue validating the upgrade process during development on 1.39? Once the 1.39 codebase is complete, we can then upgrade our data libraries all at once, removing the extra work of applying the upgrade process to these files.
jstone-lucasfilm
approved these changes
Aug 17, 2023
jstone-lucasfilm
merged commit c6dcd5d
into
AcademySoftwareFoundation:dev_1.39
14 checks passed
This was referenced Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list simplifies the way thin-film iridescence is specified in the PBR library, as discussed in issue #1384.