Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx Python Documentation #1567
Sphinx Python Documentation #1567
Changes from all commits
bef6e1f
9d4b492
e129d65
6a5da31
e1113ea
e4382bb
c983b87
3567610
abc2edb
133a0b4
67bb241
e715c0f
6a9d8e5
2c04542
8790578
0439c07
1e745bd
4c11bde
9d73ddc
0e1e502
805f13c
c0d65ed
ab6860b
26a972f
b8eecc0
bf427e4
fbe2947
f064a22
d30276b
86030d0
90c78d4
37f1ef5
aed7f8f
052f38e
939c996
77b5944
be2db5e
71bd3fd
f7bea44
e66a3f5
28fd863
74872ea
572089b
513ef90
c9a2469
21eecdd
40079f1
dfa106a
f62be3a
77ca69c
6253abc
c1b31c0
0ca9f23
f73acc4
b589282
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not specific to this PR but I noticed that images don't show up properly on the
PyPi
package page for MaterialX.If were adding more images, just curious is there a more robust way to specify image references -- such as an absolute reference to the web site location instead of using relative paths ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see the issue: https://pypi.org/project/materialx/
It's great to see that the documentation content is reused in many places!
I've migrated the Markdown docs, including
README.md
, to use absolute paths now:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of these markdown files has been split off into its own PR: #2037