1.39 update - rename atan2 inputs #1659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ld-kerley
changed the title
jstone-lucasfilm
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
This looks great to me, thanks @ld-kerley, and I'm CC'ing @dbsmythe and @niklasharrysson for their thoughts.
|
Bumping this thread, in case @dbsmythe or @niklasharrysson have thoughts; otherwise, I think we should plan to begin merging these proposals for 1.39. |
|
I have no objections! |
jstone-lucasfilm
merged commit 03d2bc2
into
AcademySoftwareFoundation:dev_1.39
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming the input ports to align correctly with the spec
in1->inyin2->inxAdd upgrade code to migrate port names found in documents.