Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade switch node to ten inputs in 1.39 #1660

Conversation

ld-kerley
Copy link
Contributor

Also added an upgrade function, which may need some closer attention. The upgrade function attempts to retain the behavior from 1.38 where any value of which that is above the accepted range that would previously been served the default (in1) value. A which value of 6 would have previously return in1, but now it would return one of the newly added inputs. To retain the previous renderer image, the document upgrader sets the value of which to the default of 0.

I'm very much open to input if this doesn't feel right.

@ld-kerley ld-kerley changed the title switch node updated to have 10 inputs, per the specification. 1.39 update - switch node updated to have 10 inputs Jan 19, 2024
ld-kerley and others added 3 commits January 18, 2024 18:15
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @ld-kerley, and I'm CC'ing @dbsmythe and @niklasharrysson for their thoughts on this alignment of our codebase with the specification.

Copy link
Contributor

@niklasharrysson niklasharrysson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too. Thanks @ld-kerley

@jstone-lucasfilm jstone-lucasfilm changed the title 1.39 update - switch node updated to have 10 inputs Upgrade switch node to ten inputs in 1.39 Jan 28, 2024
@jstone-lucasfilm jstone-lucasfilm merged commit f4c84a6 into AcademySoftwareFoundation:dev_1.39 Jan 28, 2024
31 checks passed
@ld-kerley ld-kerley deleted the update_stdlib_switch_for_1_39 branch May 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants