Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of structs in MaterialX #1831

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Initial implementation of structs in MaterialX #1831

wants to merge 24 commits into from

Commits on Sep 18, 2024

  1. Add support for recursive structs, with example. 

    Add "_struct" suffix to struct type name to avoid potential name clashes with variable names.
Add AggregateValue to centralize struct string parsing. Add support for recursive structs in places - may not be complete yet - centralized syntax parsing - and unit tests pass currently.
refactor struct experiment to not unfold the structs, but instead maintain them in the shaders
    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a338308 View commit details
    Browse the repository at this point in the history

  2. fix python unit tests.

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3c70e1e View commit details
    Browse the repository at this point in the history

  3. Addressing notes and refactor 'experimental' files to unit test locat… 

    …ions.
    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    72ae46f View commit details
    Browse the repository at this point in the history

  4. fix signed vs unsigned windows warning.

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fc7b260 View commit details
    Browse the repository at this point in the history

  5. fix signed vs unsigned windows warning (part 2)

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ac69fff View commit details
    Browse the repository at this point in the history

  6. fix unreferenced parameter warning

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7134623 View commit details
    Browse the repository at this point in the history

  7. fix dll linkage error

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    45e8468 View commit details
    Browse the repository at this point in the history

  8. fix JS error

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    36f934a View commit details
    Browse the repository at this point in the history

  9. fix typo in comment

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    9613e5b View commit details
    Browse the repository at this point in the history

  10. remove separate header declaring forward declarations.

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f7a3b6a View commit details
    Browse the repository at this point in the history

  11. Removing unit test infrastructure for now - per Jonathan - will add s… 

    …eparate PR to make this easier to review now.
    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d54ba07 View commit details
    Browse the repository at this point in the history

  12. removing separate Exceptions.h file - per Jonathans request.

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a892a8d View commit details
    Browse the repository at this point in the history

  13. refactor to use parseStructValueString()

    @ld-kerley
    ld-kerley committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1fdcfa9 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. fix unit tests

    @ld-kerley
    ld-kerley committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    483998c View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Attempting to fix windows vs2019 build failure.

    @ld-kerley
    ld-kerley committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    52d2cc3 View commit details
    Browse the repository at this point in the history

  2. Attempting to fix windows vs2019 build failure - again

    @ld-kerley
    ld-kerley committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d8b5c71 View commit details
    Browse the repository at this point in the history

  3. Update letter case 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    1aaaa1e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into struct_experiment_dont_unfold

    @jstone-lucasfilm
    jstone-lucasfilm authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    11393c0 View commit details
    Browse the repository at this point in the history

  5. Update letter case 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fba6902 View commit details
    Browse the repository at this point in the history

  6. Alphabetize includes within a module 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    33dc3c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Merge branch 'main' into struct_experiment_dont_unfold

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    217bf19 View commit details
    Browse the repository at this point in the history

  2. Remove extra newline 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    42ffa91 View commit details
    Browse the repository at this point in the history

  3. Minor formatting update 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ff98042 View commit details
    Browse the repository at this point in the history

  4. Minor formatting updates 

    Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    1378e96 View commit details
    Browse the repository at this point in the history