Add mode input to sheen_bsdf #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist adds a `mode` input to `sheen_bsdf`, allowing the user to select between Conty-Kulla and Zeltner sheen models. The Zeltner model is initially supported only in GLSL, ESSL, and MSL, integrating recent work from Stephen Hill, with OSL and MDL falling back to the Conty-Kulla model for now. The graph implementation of `open_pbr_surface` has been updated to take advantage of this new feature, and the `open_pbr_velvet.mtlx` example has been adjusted to take the visual behavior of Zeltner sheen into account.
4 tasks
Comment on lines
62
to
63
| bsdf.throughput = vec3(1.0 - dirAlbedo * weight); | ||
| bsdf.response = Li * color * dirAlbedo * weight; |
There was a problem hiding this comment.
Since these lines are the same as in the if clause, you could move them to the end (and make dirAlbedo non-local).
There was a problem hiding this comment.
Good suggestion, and will do!
jstone-lucasfilm
merged commit 3af0077
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist adds a
modeinput tosheen_bsdf, allowing the user to select between Conty-Kulla and Zeltner sheen models.The Zeltner model is initially supported only in GLSL, ESSL, and MSL, integrating recent work from Stephen Hill, with OSL and MDL falling back to the Conty-Kulla model for now.
The graph implementation of
open_pbr_surfacehas been updated to take advantage of this new feature, and theopen_pbr_velvet.mtlxexample has been adjusted to take the visual behavior of Zeltner sheen into account.