Initial translation from standard_surface to open_pbr_surface
#1934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Authored an initial pass at the translation graph between standard surface and OpenPBR 2. Added units to standard surface thin film thickness documentation
|
Copper translation example from standard surface (top) to OpenPBR (bottom) |
|
Brass tiled example from standard surface (top) to OpenPBR (bottom) |
|
Car paint translation example from standard surface (top) to OpenPBR (bottom) - could be improved |
jstone-lucasfilm
changed the title
standard_surface to open_pbr_surface
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
jstone-lucasfilm
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
This looks great to me, thanks @mkuo-lucasfilm, and I'd say that we should merge this to main, while still encouraging additional ideas and proposed improvements from the community.
jstone-lucasfilm
merged commit 5988645
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authored an initial pass at the translation graph between standard surface and OpenPBR
Added units to standard surface thin film thickness documentation