-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for choice of font for Graph Editor #2046
base: main
Are you sure you want to change the base?
Conversation
This is a very cool idea, @kwokcb! I'm CC'ing @lfl-eholthouser for her thoughts on this, and I'd be interested in what the consensus choice for a default font would be. |
I got tired of looking at the pixelated font :). I'd suggest adding a new pre-packaged "default" font is perhaps beyond the scope of this PR, as it would require packaging a font with the application which I think is different for different platforms ? |
This is really exciting to see and looks great @kwokcb! I'm not super familiar with packaging fonts but with your comment about that are you saying that the process to package the font is different per application or that certain fonts would only be available on specific applications? |
Hi @lfl-eholthouser, I think a different PR could tackle an enhancement actually package additional fonts with the executable. I haven't looked into what this means and if it may be affected by platform etc. I "think" font files can be used across platform but don't know at this point. |
Issue
The current default font is not a true-type font and does not look very good or scale well.
Propose Change
Allow the user to specify a true-type font file and size from the command line.
New options are:
--font
: desired font file to use--fontSize
: desired font size. Minimum size clamp to 12.If the font is not found or fails to load then the current built-in default font and size is used.
Font files are not packaged with the application.
Examples
imgui
)