Fix PSD import on ARM #3589
Merged
Fix PSD import on ARM #3589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code assumes "char" is "signed char" (as on x86), but on ARM "char" is "unsigned char".
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 7, 2022
The code assumes "char" is "signed char" (as on x86), but on ARM "char" is "unsigned char". Co-authored-by: Joachim Reichel <joachim.reichel@posteo.de>
|
This might be fixing this old bug report too btw: #1189 |
|
I think that's a good bet, yeah. |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 8, 2022
The code assumes "char" is "signed char" (as on x86), but on ARM "char" is "unsigned char". Co-authored-by: Joachim Reichel <joachim.reichel@posteo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code assumes "char" is "signed char" (as on x86), but on ARM "char" is "unsigned char". The local cast was the least intrusive solution, one could also change the signature of that function and cast in the caller ...
Verified with a proprietary test image. I'd guess that the OIIO testsuite should uncover the problem when run on ARM.
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).