PSD: Fix thumbnail extraction for PSD files #3668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The sanitizer failure is addressed separately by #3666, discovered along the way. But they were technically unrelated, so I made two PRs. When combined, everything works. |
Fixes 3660 In investigating this issue, I also noticed that now that IOProxy support can be relied on, the old code that in the psd reader that directly fumbles with libjpeg is not needed and can be replaced by just a couple of lines to make an ImageBuf read from an IOProxy. And it fixes the bug, too. So I'm not even going to try to figure out what was going wrong with the old code.
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 19, 2022
…n#3668) Fixes AcademySoftwareFoundation#3660 In investigating this issue, I also noticed that now that IOProxy support can be relied on, the old code that in the psd reader that directly fumbles with libjpeg is not needed and can be replaced by just a couple of lines to make an ImageBuf read from an IOProxy. And it fixes the bug, too. So I'm not even going to try to figure out what was going wrong with the old code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3660
In investigating this issue, I also noticed that now that IOProxy support can be relied on, the old code that in the psd reader that directly fumbles with libjpeg is not needed and can be replaced by just a couple of lines to make an ImageBuf read from an IOProxy.
And it fixes the bug, too. So I'm not even going to try to figure out what was going wrong with the old code.