Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing thin-film interference in combination with F82-tint metallic Fresnel #79

Closed
lukasstockner opened this issue Aug 8, 2023 · 3 comments

Comments

@lukasstockner
Copy link

The current spec draft points out the method used for implementing thin-film interference effects. However, this paper and its reference implementation assume that the physically correct dielectric and conductive Fresnel terms are used so that the optical phase shift can be computed.

However, OpenPBR uses the F82-tint model for metals, which directly computes the reflectivity without going through computing a complex IOR and then using it in the conductive Fresnel term.

Therefore, it might be helpful to include a note in the spec on how to reconcile this and how to compute/estimate the phase shift when implementing the thin-film component.

@portsmouth
Copy link
Contributor

portsmouth commented Oct 5, 2023

We discussed this and agree that it's not ideal that the interaction between the thin film and the rest of the model is under-specified.

In Arnold the thin-film effect amounts to adding some color fringes to the Fresnel term of the base (metal or dielectric) via "Airy" theory, but this involves knowing the IOR, which as you point out for the metal we no longer define. What we do in Arnold's OpenPBR implementation (for example) is convert from the F82 model to the conductor IOR using the Gulbrandsen model. We probably do need to say something about the need for such an approximation (i.e. how to interpret the physics given the not strictly physical F82 model).

@portsmouth
Copy link
Contributor

We need a PR to clarify the thin film behavior.

jstone-lucasfilm pushed a commit that referenced this issue May 7, 2024
This addresses the following:

- Implementing thin-film interference in combination with F82-tint metallic Fresnel #79
- For consistency, every section should have a "weight" parameter. #134
- Thin film in micrometers divided by 2 for normalized parameter range #150
@jstone-lucasfilm
Copy link
Member

Thanks for this original report, @lukasstockner, and it's now addressed in #167.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants