Fix transmission implementation and improve specification #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve wording/formatting in the spec Translucent base section.
There was a problem hiding this comment.
This looks like a good change, @portsmouth, though we should address the warning noted below.
jstone-lucasfilm
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
This looks good to me, @portsmouth, and most of the OpenPBR example materials work correctly with this change, though we have one example material that needs an update to render correctly:
https://github.com/AcademySoftwareFoundation/OpenPBR/blob/main/examples/open_pbr_surface_default.mtlx
I'll go ahead and approve this change, but we should make sure to fix and verify the example materials before marking an 0.3 release.
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 656945e
into
AcademySoftwareFoundation:main
1 check passed
jstone-lucasfilm
pushed a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve wording/formatting in the spec Translucent base section.
This addresses the points raised in #148.