Making roughness ranges all [0,1] #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # index.html
virtualzavie
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
LGTM.
Approved, pending resolution of the conflict between #157 and this one.
index.html
Outdated
| @@ -713,7 +713,7 @@ | |||
| \begin{equation} | |||
| V_d = \frac{\mathtt{transmission\_dispersion\_abbe\_number}} {\mathtt{transmission\_dispersion\_scale}} \ . | |||
| \end{equation} | |||
| At the default **`transmission_dispersion_scale`** of zero, the Abbe number is infinite, which corresponds to no dispersion. At the maximum of 1, the Abbe number peaks at $V_d$ = **`transmission_dispersion_abbe_number`** which defaults to 20. | |||
| At the default **`transmission_dispersion_scale`** of zero, the Abbe number is infinite, which corresponds to no dispersion. At the maximum of 1, the Abbe number peaks at $V_d = \mathtt{transmission\_dispersion\_abbe\_number}$ which defaults to 20. | |||
There was a problem hiding this comment.
Looks like this change is conflicting between #157 and here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #143, this PR fixes up the stated roughness ranges to forbid roughness > 1. It isn't useful to allow the roughness to exceed a soft-max at 1, as the appearance is unconvincing (looks like fabric, as the microfacets are mostly vertical -- which is not "rough", and we have a dedicated fuzz layer for this kind of appearance).