Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused transmission roughness from reference graph #173

Conversation

portsmouth
Copy link
Contributor

No description provided.

@jstone-lucasfilm
Copy link
Member

Isn't the transmission_roughness value still referenced in the dielectric_transmission node of the graph?

https://github.com/AcademySoftwareFoundation/OpenPBR/blob/main/reference/open_pbr_surface.mtlx#L412

Copy link
Contributor

@virtualzavie virtualzavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same comment as Jonathan.

@portsmouth
Copy link
Contributor Author

OK yup, just a misunderstanding on my part. Indeed, a rough coat should roughen the transmission lobe. This needs to be mentioned as part of #172, i.e. exactly what in the model is modified by the coat roughening effect.

@portsmouth portsmouth closed this Apr 30, 2024
@portsmouth portsmouth reopened this Apr 30, 2024
@portsmouth
Copy link
Contributor Author

portsmouth commented Apr 30, 2024

Actually, no, it does make sense. The transmission_roughness in this can be replaced with main_roughness:

   <dielectric_bsdf name="dielectric_transmission" type="BSDF">
      <input name="weight" type="float" value="1.0" />
      <input name="tint" type="color3" nodename="if_transmission_tint" />
      <input name="ior" type="float" nodename="modulated_eta_s" />
      <input name="roughness" type="vector2" nodename="transmission_roughness" />
      <input name="normal" type="vector3" interfacename="geometry_normal" />
      <input name="tangent" type="vector3" nodename="main_tangent" />
      <input name="distribution" type="string" value="ggx" />
      <input name="scatter_mode" type="string" value="T" />
    </dielectric_bsdf>

As there is no need to distinguish between the "transmission roughness" and the "reflection roughness" of the dielectric (in OpenPBR).

We do still need to clarify the implementation in #172.

@jstone-lucasfilm jstone-lucasfilm changed the title Remove unused transmission roughness section from MaterialX graph. Remove unused transmission roughness from reference graph Apr 30, 2024
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @portsmouth!

@jstone-lucasfilm jstone-lucasfilm merged commit 8824c7e into AcademySoftwareFoundation:main Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants