-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused transmission roughness from reference graph #173
Remove unused transmission roughness from reference graph #173
Conversation
Isn't the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same comment as Jonathan.
OK yup, just a misunderstanding on my part. Indeed, a rough coat should roughen the transmission lobe. This needs to be mentioned as part of #172, i.e. exactly what in the model is modified by the coat roughening effect. |
Actually, no, it does make sense. The <dielectric_bsdf name="dielectric_transmission" type="BSDF">
<input name="weight" type="float" value="1.0" />
<input name="tint" type="color3" nodename="if_transmission_tint" />
<input name="ior" type="float" nodename="modulated_eta_s" />
<input name="roughness" type="vector2" nodename="transmission_roughness" />
<input name="normal" type="vector3" interfacename="geometry_normal" />
<input name="tangent" type="vector3" nodename="main_tangent" />
<input name="distribution" type="string" value="ggx" />
<input name="scatter_mode" type="string" value="T" />
</dielectric_bsdf> As there is no need to distinguish between the "transmission roughness" and the "reflection roughness" of the dielectric (in OpenPBR). We do still need to clarify the implementation in #172. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @portsmouth!
8824c7e
into
AcademySoftwareFoundation:main
No description provided.