Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add white furnace testing section #192

Merged

Conversation

portsmouth
Copy link
Contributor

@portsmouth portsmouth commented May 14, 2024

Addresses #146.

image

image

@portsmouth
Copy link
Contributor Author

If anyone can think of other cases that should satisfy a white furnace test, please suggest them here.

index.html Outdated Show resolved Hide resolved
@virtualzavie
Copy link
Contributor

If anyone can think of other cases that should satisfy a white furnace test, please suggest them here.

  • Regardless of opacity.
  • Regardless of NDF roughness and anisotropy.

Copy link
Contributor

@virtualzavie virtualzavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@portsmouth
Copy link
Contributor Author

portsmouth commented May 14, 2024

@virtualzavie your article on the importance of the white furnace test is nice btw.. (I noticed it while scanning for ideas on how to phrase this section).

https://lousodrome.net/blog/light/2023/10/21/the-white-furnace-test/

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jstone-lucasfilm jstone-lucasfilm merged commit aa95c1b into AcademySoftwareFoundation:main May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants