Enable diffuse energy compensation #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist adds the `energy_compensation` setting to `oren_nayar_diffuse_bsdf` in the reference implementation for OpenPBR, leveraging the upcoming support for this feature in MaterialX 1.39. In recent MaterialX TSC meetings, we've aligned on this naming convention for the new energy compensation feature in oren_nayar_diffuse_bsdf, and it now seems safe to move forward with this setting in OpenPBR v1.0.
jstone-lucasfilm
merged commit a5daf05
into
AcademySoftwareFoundation:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist adds the
energy_compensationsetting tooren_nayar_diffuse_bsdfin the reference implementation for OpenPBR, leveraging the upcoming support for this feature in MaterialX 1.39.In recent MaterialX TSC meetings, we've aligned on this naming convention for the new energy compensation feature in oren_nayar_diffuse_bsdf, and it now seems safe to move forward with this setting in OpenPBR v1.0.