Implement TIR fix in MaterialX #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I was able to verify that it does work in the MaterialXView app as well. You might want to verify also @jstone-lucasfilm though. |
virtualzavie
approved these changes
May 31, 2024
There was a problem hiding this comment.
Looks good to me.
Poking @peterkutz just to catch any error I would have missed.
jstone-lucasfilm
approved these changes
May 31, 2024
jstone-lucasfilm
merged commit e33aaa0
into
AcademySoftwareFoundation:main
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without fix:
With fix:
(In the
MaterialXViewapp though, I don't see the difference. I'm not sure why, perhaps the original code is being pulled somehow?).