Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uiname field to .mtlx nodedef #204

Merged

Conversation

portsmouth
Copy link
Contributor

@portsmouth portsmouth commented May 28, 2024

Since the Maya team noted that they need this field in order to derive the node name (with correct capitalization and word break) to show in the editor:

since the name of the node is open_pbr_surface, it will require custom code to turn it into "OpenPBR Surface".

uiname metadata is already in the MaterialX specifications in the "Custom Node Declaration NodeDef Elements" section for MaterialX 1.39 and I see this as well in the old 1.38 specification. Feel free to add it to OpenPBR surface and I will make sure LookdevX uses it.

Copy link
Contributor

@AdrienHerubel AdrienHerubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@jstone-lucasfilm jstone-lucasfilm merged commit 8a17b0d into AcademySoftwareFoundation:main May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants