Clarify formula for emission color #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anderslanglands Would appreciate your thoughts on whether this change makes sense. |
virtualzavie
approved these changes
May 31, 2024
|
Makes sense to me |
|
@jstone-lucasfilm can be merged? |
jstone-lucasfilm
approved these changes
Jun 24, 2024
jstone-lucasfilm
approved these changes
Jun 24, 2024
|
@portsmouth It looks like this change is still written for the |
jstone-lucasfilm
merged commit 8d2631e
into
AcademySoftwareFoundation:dev_1.1
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion of #85, I propose to add the wording: