Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "resources" section to the front page #215

Conversation

portsmouth
Copy link
Contributor

@portsmouth portsmouth commented Jun 4, 2024

With links to

  • MaterialX web viewer running OpenPBR default material
  • OpenPBR-viewer project and web app

image

portsmouth and others added 4 commits June 4, 2024 19:34
With links to
  - MaterialX web viewer running OpenPBR default material
  - OpenPBR-viewer project and web app
@portsmouth portsmouth changed the base branch from main to dev_1.1 June 7, 2024 16:34
@portsmouth portsmouth changed the base branch from dev_1.1 to main June 7, 2024 16:37
@portsmouth
Copy link
Contributor Author

@jstone-lucasfilm is this OK to merge?

README.md Outdated Show resolved Hide resolved
@portsmouth portsmouth changed the base branch from main to dev_1.1 June 24, 2024 16:59
README.md Outdated Show resolved Hide resolved
@portsmouth
Copy link
Contributor Author

Fixed up in 97570e4, to look as below:

image

README.md Outdated
@@ -18,6 +18,12 @@ OpenPBR Surface is an open standard hosted by the [Academy Software Foundation](
* **[Reference implementation](reference/open_pbr_surface.mtlx)** – written in [MaterialX](https://materialx.org/)
* **[BibTeX citation](openpbr.bib)**

### Resources

* [MaterialX Web Viewer](https://academysoftwarefoundation.github.io/MaterialX/?file=Materials/Examples/OpenPbr/open_pbr_default.mtlx) - WebGL rasterization renderer using MaterialX [implementation](reference/open_pbr_surface.mtlx) of OpenPBR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking close to the mark, @portsmouth, though I still see some weird spacing in the text on this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 1ca6c3b

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jstone-lucasfilm jstone-lucasfilm merged commit e6427ba into AcademySoftwareFoundation:dev_1.1 Jun 25, 2024
1 check passed
Copy link
Contributor

@virtualzavie virtualzavie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the useful addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants