Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Zeltner sheen #217

Merged

Conversation

jstone-lucasfilm
Copy link
Member

This changelist enables Zeltner sheen in the reference implementation of OpenPBR, leveraging the new functionality in MaterialX 1.39.

Additionally, the open_pbr_velvet.mtlx example has been updated to account for the visual differences between Conty-Kulla and Zeltner sheen.

This changelist enables Zeltner sheen in the reference implementation of OpenPBR, leveraging the new functionality in MaterialX 1.39.

Additionally, the open_pbr_velvet.mtlx example has been updated to account for the visual differences between Conty-Kulla and Zeltner sheen.
Copy link

@theblackunknown theblackunknown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Which MaterialX version/commit is reaquired to be in sync with this change ?
Or maybe it does not matter because those changes are already replicated inside AcademySoftwareFoundation/MaterialX ?

<input name="fuzz_roughness" type="float" value="0.2" />
<input name="fuzz_roughness" type="float" value="0.5" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this empirical, or is there a closed form to fit Conty-Kulla on Zeltner one ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not aware of a closed-form solution, but we can definitely put together a good approximation and include it in a future shader translation graph from standard_surface to open_pbr_surface.

For now, I'm just estimating the visual equivalent of the original settings with Zeltner sheen, in order to roughly maintain the look of the example material in the new model.

@jstone-lucasfilm
Copy link
Member Author

Which MaterialX version/commit is reaquired to be in sync with this change ? Or maybe it does not matter because those changes are already replicated inside AcademySoftwareFoundation/MaterialX ?

This will match the very first release of MaterialX 1.39, which is technically still in development, with a release planned for the end of this month.

@jstone-lucasfilm jstone-lucasfilm merged commit 5bb9a13 into AcademySoftwareFoundation:dev_1.1 Jun 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants