Fixed AttributeError: editable_mode in setup.py #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setup.py Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
reinecke
force-pushed
the
fix/editable-mode-attributeerror
branch
from
2d3cb16 to
7ca70a1
Compare
Signed-off-by: Eric Reinecke <reinecke.eric@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1715 +/- ##
=======================================
Coverage 79.96% 79.96%
=======================================
Files 197 197
Lines 21867 21867
Branches 4338 4338
=======================================
Hits 17487 17487
Misses 2249 2249
Partials 2131 2131
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setup.pybuild_py action uses theeditable_modeattribute, however there are some invocation paths where this isn't set.This adds defaulting behavior to avoid an
AttributeErrorin those cases.Reference associated tests.
I validated this through the various
make,pip, andpython setup.py...commands.