Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ci-otio and added otio into ci-vfxall #66

Merged
merged 2 commits into from
Aug 2, 2020
Merged

Added ci-otio and added otio into ci-vfxall #66

merged 2 commits into from
Aug 2, 2020

Conversation

aloysbaillet
Copy link
Contributor

Added OpenTimelineIO CI image and added otio into ci-vfxall.
Also made sure you can use otioview

docker run --gpus=all -e DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix:rw -v ~/OpenTimelineIO/tests/sample_data:/d --rm -it aswftesting/ci-vfxall:2019 otioview /d/nucoda_example.edl

otioview

Fixes #64

@aloysbaillet
Added ci-otio and added otio into ci-vfxall
6b08f9b 
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
@aloysbaillet
Added docs on how to add new ci images
ab88180 
Signed-off-by: Aloys Baillet <aloys.baillet+github@gmail.com>
jfpanisset
jfpanisset approved these changes Aug 1, 2020
View reviewed changes
Copy link
Contributor

@jfpanisset jfpanisset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm sure the OTIO team will enjoy this.

scripts/vfx/build_otio.sh

set -ex

git clone https://github.com/PixarAnimationStudios/OpenTimelineIO.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a centralized file that has the canonical repo locations for all the projects instead of having those in the project-specific build scripts? At some point the OTIO repo will move to the AcademySoftwareFoundation GitHub organization, and since builds will still work due to GitHub redirects, it could be easy to forget to update this hard coded repo path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will replace these scripts by rez packages pretty soon, and at that point we could indeed centralise so repository locations, at least for the ASWF repos... What do you think?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OTIO team will enjoy this :) Thanks so much Aloys!!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rez packages are an intriguing notion! I'm sure several of us can keep an eye open to have this script updated when the repo migrates to ASWF.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about Rez to comment on the implications, but sounds like you have a plan!

meshula
meshula approved these changes Aug 2, 2020
View reviewed changes
Copy link

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited and happy to see this! Thanks so much!

@aloysbaillet
Copy link
Contributor Author

No worries, give me a few hours to release everything :-)

@aloysbaillet aloysbaillet merged commit ea92767 into AcademySoftwareFoundation:master Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfpanisset jfpanisset jfpanisset approved these changes

@meshula meshula meshula approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opentimelineio
3 participants
@aloysbaillet @meshula @jfpanisset