Removed boost/any in favour of openvdb::MetaMap usage #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idclip
commented
Jun 18, 2020
openvdb/points/PointDataGrid.h
Outdated
| } | ||
| } | ||
|
|
||
| } // namespace page_stream |
There was a problem hiding this comment.
@danrbailey be good for you to take a look through this - I started splitting out all the descriptor methods from the Local structs into a shared namespace too, but there's ever so slightly different implementations of some. Would be good to consolidate them
Idclip
commented
Jun 18, 2020
openvdb/points/PointDataGrid.h
Outdated
| using TypedMetaT = TypedMetadata<typename StreamT::Ptr>; | ||
|
|
||
| const std::string key("paged:" + std::to_string(index)); | ||
| typename TypedMetaT::ConstPtr it = auxData.getMetadata<TypedMetaT>(key); |
There was a problem hiding this comment.
note - getMetadata performs string type checks. If we don't want to do that, we can use static_cast<...>(auxData[key])
|
@danrbailey bump |
danrbailey
approved these changes
May 2, 2023
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
Signed-off-by: Nick Avramoussis <4256455+Idclip@users.noreply.github.com>
jmlait
approved these changes
Sep 10, 2024
|
This PR has now been superceded by this one (#1687), closing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.