Skip to content

Commit

Permalink
Merge pull request #772 from bfloch/feature/skip_windows_cmake_test
Browse files Browse the repository at this point in the history
Skip `test_build_cmake` on Windows.
  • Loading branch information
nerdvegas authored Oct 24, 2019
2 parents 35470a9 + 5effe63 commit 3d32dd3
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,12 @@ like any other package:
* Has a memcached-based caching system, for caching environment resolves;
* Has a package filtering feature, allowing for staged package releases such as
alpha and beta packages.

## Known issues and limitations

* Currently CMake builds do not function on Windows with Rez and
the related tests are skipped. A fix requires multiple changes that are on
the roadmap. Users have successfully implemented workarounds to utilize
CMake with Rez under Windows, but the goal is to provide a seamless experience
on any platform in the future. For details checkout
https://github.com/nerdvegas/rez/issues/703
6 changes: 6 additions & 0 deletions src/rez/tests/test_build.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import unittest
from rez.tests.util import TestBase, TempdirMixin, find_file_in_path, \
per_available_shell, install_dependent, program_dependent
from rez.utils.platform_ import platform_
import shutil
import os.path

Expand Down Expand Up @@ -155,6 +156,11 @@ def test_builds_anti(self):
@program_dependent("cmake")
def test_build_cmake(self):
"""Test a cmake-based package."""
if platform_.name == "windows":
self.skipTest("This test does not run on Windows due to temporary"
"limitations of the cmake build_system plugin"
" implementation.")

self.assertRaises(PackageFamilyNotFoundError, self._create_context,
"sup_world==3.8")
self._test_build_translate_lib()
Expand Down

0 comments on commit 3d32dd3

Please sign in to comment.