-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rez-pip should assume python provided pip #706
Comments
Could it be made possible to influence the request for pip made in step 4? I have had times where I needed to test against one rezified pip over another. |
What happens if the python version is not requested? We take the latest? Or we simply make the What do you think? |
I think it's more "rezish"(?) to just default to latest python package
found - not specifying python version should be equivalent to a 'rez-env
python' if you see what I mean.
Wrt specific rezified pip - I wouldn't put too much effort into this, since
we know we're headed to a place (py3) where we expect pip to be provided by
python itself. In the meantime, it's not so hard to alter REZ_PACKAGES_PATH
to get the correct pip chosen anyway. Having said that, I think better
logging verbosity and addition of a `--dry-run` mode would further justify
leaving things as they are.
A
…On Mon, Sep 2, 2019 at 12:07 AM Jean-Christophe Morin < ***@***.***> wrote:
Search for rezified python matching python version request;
What happens if the python version is not requested? We take the latest?
Or we simply make the --python-version mandatory? I think I'd go with
--python-version being mandatory so that it is more explicit which
version is taken and avoids mistakes and better fits with the general
philosophy of /path/to/python -m pip.
What do you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#706>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMOUSQHNXPXCTQEBZYYH4TQHPECJANCNFSM4ISJ5LEQ>
.
|
Newer python versions ship with pip, however rez-pip first searches for a rezified pip package, falling back to its own pip installation if one isn't found.
Instead, rez-pip should (in this order):
The rez-pip
--pip-version
arg should also be marked as deprecated (though not removed just yet).The text was updated successfully, but these errors were encountered: