Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rez-pip should assume python provided pip #706

Closed
nerdvegas opened this issue Aug 30, 2019 · 3 comments · Fixed by #757
Closed

rez-pip should assume python provided pip #706

nerdvegas opened this issue Aug 30, 2019 · 3 comments · Fixed by #757
Assignees

Comments

@nerdvegas
Copy link
Contributor

nerdvegas commented Aug 30, 2019

Newer python versions ship with pip, however rez-pip first searches for a rezified pip package, falling back to its own pip installation if one isn't found.

Instead, rez-pip should (in this order):

  • Search for rezified python matching python version request;
  • If found, test if pip is present;
  • If pip is present, use it;
  • If not present, search for rezified pip (this is for backwards compatibility);
  • If rezified pip is found, use it;
  • If not, fall back to rez's python installation.

The rez-pip --pip-version arg should also be marked as deprecated (though not removed just yet).

@maxnbk
Copy link
Contributor

maxnbk commented Aug 30, 2019

Could it be made possible to influence the request for pip made in step 4? I have had times where I needed to test against one rezified pip over another.

@JeanChristopheMorinPerso
Copy link
Member

Search for rezified python matching python version request;

What happens if the python version is not requested? We take the latest? Or we simply make the --python-version mandatory? I think I'd go with --python-version being mandatory so that it is more explicit which version is taken and avoids mistakes and better fits with the general philosophy of /path/to/python -m pip.

What do you think?

@nerdvegas
Copy link
Contributor Author

nerdvegas commented Sep 2, 2019 via email

JeanChristopheMorinPerso added a commit to JeanChristopheMorinPerso/rez that referenced this issue Oct 4, 2019
JeanChristopheMorinPerso added a commit to JeanChristopheMorinPerso/rez that referenced this issue Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants