Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds more variables to the custom build system. #1013

Conversation

bfloch
Copy link
Contributor

@bfloch bfloch commented Jan 22, 2021

This patch adds more commands to the custom build system.

The reason is that we might be able to define more commands directly without intermediate bash or python scripts
if certain data is available in the build_command. Most prominently install_path so that we can for example satisfy build systems like:

build_command = "python setup.py --install-dir {build_path}"

This also eliminates the need to grab the environment should you prefer to handle build scripts via arguments only, which is a little more verbose to understand the action from the package.py

The full list of supported variables to the build_command are now:

  • build_path
  • install (retained)
  • install_path
  • name
  • root (retained)
  • variant_index (or empty string if non is given)
  • version

Also adressed minor spelling/formatting issue and removed unnecessary temporary variables.

This will not break compatibility but due the the simplicity I did not add unit-tests. Let me know if you would prefer any.

The full list of supported variables to the build_command are now:
- build_path
- install (retained)
- install_path
- name
- root (retained)
- variant_index
- version
@nerdvegas
Copy link
Contributor

Looks good, however for completeness https://github.com/nerdvegas/rez/wiki/Package-Definition-Guide#build_command needs to be updated also to include the new fields.

@nerdvegas nerdvegas merged commit 5ef501b into AcademySoftwareFoundation:master Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants