Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing comma in Legacy Metadata #1092

Merged

Conversation

bfloch
Copy link
Contributor

@bfloch bfloch commented Jun 3, 2021

This fixes rez-pip install for packages that have a trailing comma on
version requirements.

For example openpyxl will now install properly with this line:

Requires-Python: >=3.6,
                      ^ Parser will fail without the patch

Not sure if you rather want to wait for upstream.

This fixes rez-pip install for packages that have a trailing comma on
version requirements.
For example openpyxl will now install properly with this line:
> Requires-Python: >=3.6,
Worth submitting upstream.
@bfloch
Copy link
Contributor Author

bfloch commented Jun 3, 2021

@nerdvegas nerdvegas merged commit 0760a38 into AcademySoftwareFoundation:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants