Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add platform/arch to variant for rez-pip packages with entry point scripts #1287

Conversation

bpabel
Copy link
Contributor

@bpabel bpabel commented Apr 16, 2022

Fixes #1286

@bpabel bpabel requested a review from nerdvegas as a code owner April 16, 2022 05:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

src/rez/utils/pip.py Show resolved Hide resolved
src/rez/utils/pip.py Show resolved Hide resolved
@JeanChristopheMorinPerso
Copy link
Member

I looked at the build failures and I'm not too sure what's going on. And our builds are being massively queued right now, which makes debugging quite difficult.

Also, you will have to sign off your commits. See https://github.com/AcademySoftwareFoundation/rez/pull/1287/checks?check_run_id=6716785034.

@bpabel bpabel force-pushed the fix/1286-rez-pip-variant branch 2 times, most recently from f087b1a to 727a1d0 Compare June 30, 2022 13:26
@JeanChristopheMorinPerso
Copy link
Member

Hey @bpabel , can you rebase your branch with master please? That should fix the windows build issues. Thanks!

@JeanChristopheMorinPerso
Copy link
Member

Actually, wait a little bit, we have another failure on master.

@JeanChristopheMorinPerso
Copy link
Member

Alright, you can rebase now. The issue has been fixed and the workflow should work.

bpabel added 3 commits July 2, 2022 11:17
…nt scripts

Signed-off-by: Brendan Abel <007brendan@gmail.com>
Signed-off-by: Brendan Abel <007brendan@gmail.com>
Signed-off-by: Brendan Abel <007brendan@gmail.com>
@bpabel bpabel force-pushed the fix/1286-rez-pip-variant branch from 727a1d0 to 538ba0e Compare July 2, 2022 16:17
@bpabel
Copy link
Contributor Author

bpabel commented Jul 2, 2022

@JeanChristopheMorinPerso Cool, thanks. Rebased and updated from your notes. Looks like builds are succeeding now.

Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @instinct-vfx any opinion on this before we merge this PR?

@JeanChristopheMorinPerso JeanChristopheMorinPerso added this to the 2.112.0 milestone Oct 22, 2022
@instinct-vfx
Copy link
Contributor

I did not have the chance to actually test myself but it looks good to me and is also an important fix (specifically on windows). At some time in the future i would like to revisit rez-pip, move to a more sensible approach to the file mapping and also add less specific variants for pure python packages without entrypoints. Good one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rez-pip doesn't include arch/platform in variant for packages with platform-specific generated scripts
4 participants