-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REZ_USED_LOCAL_RESOLVE context environment variable #1378
Add REZ_USED_LOCAL_RESOLVE context environment variable #1378
Conversation
|
Populate the environment variable "REZ_USED_LOCAL_RESOLVE" in the same style as REZ_USED_EPH_RESOLVE for any packages resolved to a local destination Signed-off-by: Josh <josh@kelly.camera>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. That's exactly what I was imagining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with what's been done here, but the docs need updating here: https://github.com/AcademySoftwareFoundation/rez/wiki/Environment-Variables#context-environment-variables
Take care to note that this new envvar will contain a subset of what's already in REZ_USED_RESOLVE.
You just need to update this file, the wiki will be updated for you: https://github.com/AcademySoftwareFoundation/rez/blob/master/wiki/pages/Environment-Variables.md
Signed-off-by: Josh <josh@kelly.camera>
@nerdvegas How's that look? |
Thanks for documenting it! To me it looks great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The requested change was correctly made
Populate the environment variable "REZ_USED_LOCAL_RESOLVE" in the same style as REZ_USED_EPH_RESOLVE for any packages resolved to a local destination
Closes #1371
Let me know if there's a version number I need to bump or something