-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
powershell: fix prepend for new variables and fix unsetenv for non-existing variables #1477
Conversation
4e0b7fd
to
e134aff
Compare
90e75e5
to
3b9733c
Compare
If the contributor checks the "Allow maintainers to edit PR", the contributor grants the admins/maintainers access to push to their branch in their fork. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests.
|
Gotcha, good to know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: SitiSchu <admin@sitischu.com>
…unset' and 'prependenv' Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
Signed-off-by: Stephen Mackenzie <maxnbk@users.noreply.github.com>
7ccc15d
to
0087825
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #1476
Supercedes PR by @SitiSchu on #1434 (but includes his commit cherrypicked to maintain history/credit)
The test, and commits, also address the same issue but in the "unset" logic, because that too is a victim of this same issue, which is validated by the test, and was in fact the reason I came complaining to @instinct-vfx about not understanding something I was seeing, I just wasn't bright enough to understand it right away.